Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔌 Load plugins from all site projects, rather than just "current project" #1119

Merged
merged 1 commit into from
Apr 17, 2024
Merged

🔌 Load plugins from all site projects, rather than just "current project" #1119

merged 1 commit into from
Apr 17, 2024

Conversation

fwkoch
Copy link
Collaborator

@fwkoch fwkoch commented Apr 17, 2024

When loading plugins, we were previously only loading from currentProjectConfig. This PR updates the loading logic to also look at the currentSiteConfig and load all plugins from each of the site's projects.

@fwkoch fwkoch mentioned this pull request Apr 17, 2024
Closed
stevejpurves
stevejpurves approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@stevejpurves stevejpurves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works well on a site with 2 sub projects, plugins in the first sub project are picked up correctly

@fwkoch fwkoch merged commit 9b92af5 into main Apr 17, 2024
4 checks passed
@fwkoch fwkoch deleted the feat/multi-proj-plugins branch April 17, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevejpurves stevejpurves stevejpurves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fwkoch @stevejpurves